Member-only story

How to have the Best Code Review?

Mohammad Kallaf Alhjaj
6 min readNov 25, 2023

--

β€œTo avoid criticism say nothing, do nothing, be nothing.”

― Elbert Hubbard

Software development is more than just writing code, it's a complex process that connects different people to produce software with the best quality and meet the client's expectations.

Part of this process is when a developer tries to finalize a task by submitting a pull request.

One of the most frustrating things that developers face is code reviews.

So let's start by discovering why it can be frustrating From the Author's (Change owner) perspective.

Unclear or Inconsistent Guidelines

Lack of clear standards can make it challenging to know what is expected in terms of coding style, documentation, and best practices.

Lack of Context in Feedback

If feedback is provided without context or explanation.

Unrealistic Expectations

If the review process focuses too heavily on minor details rather than the overall functionality and purpose of the code.

Delays in Reviews

If there are significant delays in getting the code reviewed.

Lack of Recognition for Effort

If positive aspects of the code changes go unnoticed or unacknowledged.

Overwhelmed by Feedback

Overwhelming amount of feedback, especially if the feedback is not well-organized or if there is a lack of guidance on which issues are most critical.

Repetitive Feedback

Receiving the same feedback repeatedly across multiple code reviews.

Disagreements Without Constructive Resolution

--

--

Mohammad Kallaf Alhjaj
Mohammad Kallaf Alhjaj

Written by Mohammad Kallaf Alhjaj

Senior Software Engineer, Write about Programming, Technology and Workplace

No responses yet

Write a response